Update CrossClusterShardTests to account for TransportRequestHandler and less manual inspection #110989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
needs:triage
mark-vieira
previously approved these changes
Jul 17, 2024
jakelandis
added
>non-issue
:Security/Security
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Contributor
Author
|
@elasticsearchmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the CrossClusterShardTests introduced with #101656 to account for TransportRequestHandler.
It also introduces reflections to provide stronger, but still imperfect, educated guesses to which actions and requests
should implement the
IndicesRequest.RemoteClusterShardRequestinterface. The updated test re-enforced that theinterface was correctly applied in #101656, but the new checks also found a couple classes that should also implement
the interface. Those classes have been updated to implement the
IndicesRequest.RemoteClusterShardRequestinterface.